Support symbol stroke and opacity #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for strokes around symbol marks for both circle and path shapes. Also adds support for fill and stroke opacity.
Supporting strokes while drawing symbols of varying sizes using instancing is a bit subtle. If you simply scale the stroke vertices along with the fill vertices to change the symbols size, the stroke will be thicker for large marks and thinner for small marks. To compensate for this, the stroke vertex normals (as returned by lyon) are transferred to the vertex shader and the stroke vertices are shifted along their normal vector to generate consistent sizing.